ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Flows | Book library - #183
ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Flows | Book library#183Priscilla-EM wants to merge 6 commits into
Conversation
Priscilla-EM
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
I think there are some improvements you can still make to the JS code.
Also, when I checked the code in index.html at https://validator.w3.org/, it indicated some errors.
| author.value == null || | ||
| author.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" |
There was a problem hiding this comment.
In terms of input validation,
- Are all input properly checked?
- Can
.valuebenull? (Do we need to checksomeInputElement.value == null?) - What if a user enters only space characters in the "title" input field?
- What if a users enters
-1or3.1416in the "pages" input field?
| for (let n = rowsNumber - 1; n > 0; n-- ){ | ||
| table.deleteRow(n); | ||
| } |
There was a problem hiding this comment.
Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?
There was a problem hiding this comment.
Line 71: With the way the book's title is assigned to an HTML element, a book with a title containing special character sequence such as <i> can possibly ruin the display.
Lines 77, 95:
- Is the value assigned to these
idattribute unique? - Is there a need to assign an id attribute to
delButton? - Is there a need to assign an id attribute to
changeBut(at line 72)?
Lines 76, 94:
- Can you think of a more consistent way to name the variables representing the two buttons,
changeButanddelButton?
cjyuan
added
Reviewed
|
On separate note, the "Changelist" part in the PR Template is not edited accordingly. It is a common best practice to include a short description of the PR in the first comment.
|
Priscilla-EM
added
the
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
This PR implements a simple Book Library web app using HTML, CSS, and JavaScript. Users can add books with a title, author, page count, and read status. Each book is displayed in a table, with options to toggle its read status or delete it
Questions
Ask any questions you have for your reviewer.